fix(api-graphql): close WS on events.closeAll #13989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iartemiev
commented
Nov 6, 2024
| await fn(); | ||
| await Promise.resolve(); |
There was a problem hiding this comment.
This line is redundant and has no effect on any of the tests. Removing it for clarity.
atierian
approved these changes
Nov 6, 2024
svidgen
reviewed
Nov 6, 2024
There was a problem hiding this comment.
My brain's missing something. Can you add an explanation in a docstring as to why the awsRealTimeSocket only needs to be closed in the on provider? The PR description says it's to "limit blast radius" of the change. But, that makes it sound like we have more research to do.
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
events.closeAll()is intended to close the WS connection, disconnect listeners and reconnect observers. However, the underlyingAWSWebSocketProvider.close()method does all of the above, except for close the WS connection.To limit the blast radius of this change, this PR only modifies the
AWSAppSyncEventProvidersub class, closing the WS connection onclose()and leaves the AppSyncRealTimeProvider unchanged.Issue #, if available
#13984
Description of how you validated changes
Checklist
yarn testpasses