Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: upgrade action/upload-artifact to 4.5.0 #14127

Merged
merged 6 commits into from
Jan 9, 2025
Merged

chore: upgrade action/upload-artifact to 4.5.0 #14127

merged 6 commits into from
Jan 9, 2025

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Jan 9, 2025 •
edited
Loading

Description of changes

The current upload artifact action v3 is deprecating: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Issue #, if available

https://github.com/aws-amplify/amplify-js/actions/runs/12695537419

Description of how you validated changes

Verified with e2e test: https://github.com/aws-amplify/amplify-js/actions/runs/12696280106?pr=14127
#14127

Verified upload: https://github.com/aws-amplify/amplify-js/actions/runs/12697021454/job/35392601742?pr=14127#step:5:7116

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP force-pushed the upgrade-upload-action branch from f728c69 to 4a3d4f6 Compare January 9, 2025 19:20
@AllanZhengYP AllanZhengYP marked this pull request as ready for review January 9, 2025 19:46
@AllanZhengYP AllanZhengYP requested a review from a team as a code owner January 9, 2025 19:46
@AllanZhengYP AllanZhengYP merged commit c279ae0 into main Jan 9, 2025
31 checks passed
@AllanZhengYP AllanZhengYP deleted the upgrade-upload-action branch January 9, 2025 19:55
HuiSF pushed a commit that referenced this pull request Jan 23, 2025
@AllanZhengYP @HuiSF
chore: upgrade action/upload-artifact to 4.5.0 (#14127)
a55cdbb
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cshfang cshfang cshfang approved these changes

@HuiSF HuiSF HuiSF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllanZhengYP @cshfang @HuiSF