Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

V1 make cfnLint keyword dynamic #3225

Merged
merged 5 commits into from
May 9, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented May 9, 2024

Issue #, if available:

Description of changes:

  • Build the capability to dynamically build cfnLint keywords. This allows customers to create a rule with a keyword like Resources/AWS::ApiGateway::RestApi/Properties to evaluate all resources in a template of type AWS::ApiGateway::RestApi. This allows us to remove a bunch of patching we were doing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong changed the title V1 cleanup/2024/05/08 V1 make cfnLint keyword dynamic May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (c6f3d66) to head (50f2060).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3225      +/-   ##
==========================================
+ Coverage   92.39%   92.40%   +0.01%     
==========================================
  Files         303      303              
  Lines       10662    10663       +1     
  Branches     2273     2273              
==========================================
+ Hits         9851     9853       +2     
+ Misses        471      467       -4     
- Partials      340      343       +3     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 3c2891f into aws-cloudformation:main May 9, 2024
22 checks passed
@kddejong kddejong deleted the v1-cleanup/2024/05/08 branch May 9, 2024 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant