Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pin ACK runtime to v0.32.0 #516

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Mar 4, 2024

Propagating two main patches to all the controllers:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
Copy link

ack-prow bot commented Mar 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2024
@a-hilaly a-hilaly marked this pull request as ready for review March 4, 2024 22:37
@ack-prow ack-prow bot requested review from jlbutler and jljaco March 4, 2024 22:37
@ack-prow ack-prow bot added approved and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 4, 2024
@a-hilaly a-hilaly changed the title Pin ACK runtime to v0.32.0 Pin ACK runtime to v0.32.0 Mar 4, 2024
@a-hilaly
Copy link
Member Author

a-hilaly commented Mar 4, 2024

/retest

@yuxiang-zhang
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link

ack-prow bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, yuxiang-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@a-hilaly
Copy link
Member Author

a-hilaly commented Mar 4, 2024

/retest

1 similar comment
@a-hilaly
Copy link
Member Author

a-hilaly commented Mar 5, 2024

/retest

@ack-prow ack-prow bot merged commit 0208d82 into aws-controllers-k8s:main Mar 5, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants