Skip to content

chore: Adding Validation step for IaC with SAM #1498

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 50 commits into from

Conversation

jasoniharris
Copy link
Contributor

@jasoniharris jasoniharris commented Oct 31, 2023

**Issue #, if available: #1459 **

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Jason Harris and others added 30 commits October 2, 2023 13:39
…tests too and is more idiomatic and readme to be more descriptive
…tests too and is more idiomatic and readme to be more descriptive
@jasoniharris jasoniharris changed the title Adding Validation step for IaC with SAM Maintenance: Adding Validation step for IaC with SAM Oct 31, 2023
@jeromevdl jeromevdl changed the title Maintenance: Adding Validation step for IaC with SAM chore: Adding Validation step for IaC with SAM Oct 31, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 1, 2023
@jeromevdl
Copy link
Contributor

@jasoniharris is there anything else? it's still in draft...

@scottgerring
Copy link
Contributor

@jasoniharris - build failing - if this gets too fiddly, suggest rebranching in the repo itself, as the builds will run automatically then.

@jasoniharris jasoniharris marked this pull request as ready for review November 15, 2023 13:34
@jeromevdl
Copy link
Contributor

@jasoniharris, would you open another PR with a "local" branch?

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jasoniharris
Copy link
Contributor Author

Raised this branch instead - Closing this PR
#1533

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants