Skip to content

fix(batch): bugfix to clear exceptions between executions #1022

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Feb 11, 2022

Issue #, if available:

closes #1021

Description of changes:

Changes:

  • Add failing test
  • Add part of _prepare we should also clear the exceptions list, so that cold starts and warm starts behave the same.

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2022
@github-actions github-actions bot added the bug Something isn't working label Feb 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #1022 (0475b5d) into develop (77f86c0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1022   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5364     5365    +1     
  Branches       612      612           
========================================
+ Hits          5362     5363    +1     
  Partials         2        2           
Impacted Files Coverage Δ
aws_lambda_powertools/utilities/batch/base.py 99.21% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f86c0...0475b5d. Read the comment docs.

@pull-request-size pull-request-size bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2022
@boring-cyborg boring-cyborg bot added the tests label Feb 11, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2022
@michaelbrewer michaelbrewer changed the title fix(batch): clear exceptions for consistency fix(batch): clear batch exceptions for consistency between warm and cold starts Feb 11, 2022
@heitorlessa heitorlessa changed the title fix(batch): clear batch exceptions for consistency between warm and cold starts fix(batch): bugfix to clear exceptions between executions Feb 14, 2022
@heitorlessa heitorlessa merged commit a70c181 into aws-powertools:develop Feb 14, 2022
@heitorlessa heitorlessa deleted the fix-1021 branch February 14, 2022 08:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch: different behaviour for all-items-failed in cold start vs. warm start
3 participants