docs(apigateway): add all resolvers in testing your code section for accuracy #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2022 17:09
Signed-off-by: Bruno Souza <bruno@komu.com.br>
Signed-off-by: Bruno Souza <bruno@komu.com.br>
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
the
size/S
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
size/M
pull-request-size
bot
added
size/L
heitorlessa
requested review from
heitorlessa
and removed request for
mploski
|
@bnsouza could you review the changes I've made just in case I missed anything? Changes:
|
bnsouza
commented
Nov 8, 2022
added 4 commits
November 8, 2022 17:22
Signed-off-by: Bruno Souza <bruno@komu.com.br>
Signed-off-by: Bruno Souza <bruno@komu.com.br>
Signed-off-by: Bruno Souza <bruno@komu.com.br>
Signed-off-by: Bruno Souza <bruno@komu.com.br>
|
I made it! But if you think it's better remove or change, it's ok! Abraços! |
|
np at all! For future reference, we add all variants of the payloads we encounter under "test/events" - we found docs not to be a reliable source at times |
heitorlessa
approved these changes
Nov 9, 2022
heitorlessa
changed the title
|
Merging now - thank you again! Nice touch on adding the payload link as a comment! |
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
heitorlessa
added a commit
to ascopes/aws-lambda-powertools-python
that referenced
this pull request
Nov 14, 2022
* develop: (155 commits) chore: apigw test event wrongly set with base64 chore(deps-dev): bump types-requests from 2.28.11.3 to 2.28.11.4 (aws-powertools#1701) update changelog with latest changes feat(apigateway): multiple exceptions in exception_handler (aws-powertools#1707) chore(deps-dev): bump mypy-boto3-logs from 1.25.0 to 1.26.3 (aws-powertools#1702) update changelog with latest changes chore(ci): revert custom hw for E2E due to lack of hw update changelog with latest changes docs: project name consistency chore(ci): prevent dependabot updates to trigger E2E chore(ci): use new custom hw for E2E chore(ci): limit to src only to prevent dependabot failures update changelog with latest changes docs(examples): linting unnecessary whitespace chore(deps-dev): bump pytest-xdist from 2.5.0 to 3.0.2 (aws-powertools#1655) update changelog with latest changes docs(apigateway): add all resolvers in testing your code section for accuracy (aws-powertools#1688) chore(deps-dev): bump mkdocs-material from 8.5.7 to 8.5.9 (aws-powertools#1697) update changelog with latest changes docs(homepage): update default value for `POWERTOOLS_DEV` (aws-powertools#1695) ...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1686
Summary
Changes
I've changed the example for testing API Gateway. Changed the
examples/event_handler_rest/src/assert_http_response.pyanddocs/core/event_handler/api_gateway.md.Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
View rendered docs/core/event_handler/api_gateway.md