-
Notifications
You must be signed in to change notification settings - Fork 434
feat(data-classes): add AttributeValueType to DynamoDBStreamEvent #462
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(data-classes): add AttributeValueType to DynamoDBStreamEvent #462
Conversation
Changes: Add new enum AttributeValueType for the type of AttributeValue Add new method `get_type` to return said enum
Codecov Report
@@ Coverage Diff @@
## develop #462 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 105 105
Lines 4202 4231 +29
Branches 205 205
========================================
+ Hits 4198 4227 +29
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
@gwlester what do you think? |
Looks great! Thanks for the fast work! |
aws_lambda_powertools/utilities/data_classes/dynamo_db_stream_event.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll release 1.17.0 tomorrow and I could get this included too, if we could have an example usage in the docs. Thanks a lot!
Will this be in the next Release? |
- Refactor value to get_value - Add code example
Thanks @michaelbrewer for the changes! I'm gonna look into the CI failures |
Failures seem to be intermittent getting the codecov token |
Yeah I raised a ticket back then and seemed resolved for a while.
I also noticed concurrent doc builds fail due to git divergence when using
Mike
…On Tue, 8 Jun 2021 at 06:17, Michael Brewer ***@***.***> wrote:
Thanks @michaelbrewer <https://github.com/michaelbrewer> for the changes!
I'm gonna look into the CI failures
Failures seem to be intermittent getting the codecov token
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBEONM7D62KQZVLNPETTRWKWHANCNFSM46FQ3JSQ>
.
|
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: chore(deps): bump boto3 from 1.17.88 to 1.17.89 (#466) feat(data-classes): add AttributeValueType to DynamoDBStreamEvent (#462) chore(deps): bump boto3 from 1.17.87 to 1.17.88 (#463) chore(deps-dev): bump mkdocs-material from 7.1.6 to 7.1.7 (#464) feat(data-classes): decorator to instantiate data_classes and docs updates (#442) chore(deps): bump boto3 from 1.17.86 to 1.17.87 (#459)
FYI, added it into the code (Dynamo Stream -> Lambda -> TimeStream -- for audit trail) and it works great!!! Thanks again! |
Fantastic to hear!
…On Wed, 9 Jun 2021 at 22:29, Gerald Leter ***@***.***> wrote:
FYI, added it into the code (Dynamo Stream -> Lambda -> TimeStream -- for
audit trail) and it works great!!!
Thanks again!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#462 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBESHOLPZGB4VE3GMRDTR7FL3ANCNFSM46FQ3JSQ>
.
|
Issue #, if available:
#461
Description of changes:
Changes:
get_type
to return said enumget_value
which returns converted valueExample usage:
Where
AttributeValueType
is:How AttributeValue does the raw values
Example Values:
{"B": "dGhpcyB0ZXh0IGlzIGJhc2U2NC1lbmNvZGVk"}
{"BS": ["U3Vubnk=", "UmFpbnk=", "U25vd3k="]}
{"BOOL": True}
{"L": [ {"S": "Cookies"} , {"S": "Coffee"}, {"N": "3.14159"}]}
{"M": {"Name": {"S": "Joe"}, "Age": {"N": "35"}}}
{"N": "123.45"}
{"NS": ["42.2", "-19", "7.5", "3.14"]}
{"NULL": True}
{"S": "Hello"}
{"SS": ["Giraffe", "Hippo" ,"Zebra"]}
Return types
How Dynamodb Type does deserialization
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.