Skip to content

feat(tracer): add service annotation when service is set #861

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Nov 30, 2021

Issue #, if available: #850

Description of changes:

When setting service parameter or POWERTOOLS_SERVICE_NAME, Tracer will add a new annotation named Service to ease filtering a given component by service. Often times, this is used to create more meaningful X-Ray Trace Groups for larger applications.

image

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/core/tracer.md

@boring-cyborg boring-cyborg bot added area/tracer documentation Improvements or additions to documentation internal Maintenance changes tests labels Nov 30, 2021
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2021
@heitorlessa
Copy link
Contributor Author

Tested against an actual service to be triple sure, cc @cakepietoast. I'm gonna merge as I know you're busy

image

@heitorlessa heitorlessa added the feature New feature or functionality label Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #861 (b0c0188) into develop (1ad18c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #861   +/-   ##
========================================
  Coverage    99.90%   99.90%           
========================================
  Files          118      118           
  Lines         5110     5125   +15     
  Branches       280      283    +3     
========================================
+ Hits          5105     5120   +15     
  Misses           2        2           
  Partials         3        3           
Impacted Files Coverage Δ
aws_lambda_powertools/tracing/tracer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad18c9...b0c0188. Read the comment docs.

@michaelbrewer
Copy link
Contributor

@heitorlessa - don't miss this in the changelog, a super cool improvement

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation feature New feature or functionality internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants