Force database parameter must be omitted or have the same value as schema

[armaseg]

resolves #93

Description

Changes in credentials

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[nicor88]

@armaseg when testing this PR (I removed my database from my profile). I'm getting this error:

Credentials in profile "glue", target "dev" invalid: 'database' is a required property

I see bunch of places where the database is used:

• sample profile: https://github.com/aws-samples/dbt-glue/blob/main/dbt/include/glue/sample_profiles.yml#L21
• this macro:

  dbt-glue/dbt/include/glue/macros/adapters.sql

  Line 92 in 3c86a8a

  {%- set default_database = target.database -%}

  , should be rather target.schema
• seeds:

  dbt-glue/dbt/include/glue/macros/materializations/seed.sql

  Lines 10 to 11 in 1b50527

  	{%- set old_relation = adapter.get_relation(database=database, schema=schema, identifier=identifier) -%}
  	{%- set target_relation = api.Relation.create(database=database, schema=schema, identifier=identifier,

If I understood correctly with this feature we should be able to don't pass the database in the profile, am I right? If so, some other tweaks are needed.

[armaseg]

Totally missed it! Thank you @nicor88 :)

[nicor88]

@armaseg I tested your latest changes, it works well (again I omitted database from my profile). Thanks for your changes. For me this is ready to be 🚢

[nicor88]

@armaseg So I tested the following:

• a simple dbt run on a model ✅
• dbt seed with a sample csv (I did run it multiple times just to be sure) ✅

so far all works well.