Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Updated README to remove references of old pre-flight checks #114

Merged

Conversation

quixoticmonk
Copy link
Contributor

@quixoticmonk quixoticmonk commented May 4, 2023

Summary

Updates the README to remove the references of pre/post-flight checks from the process.

Changes

  • Updated README to remove the pre/post-flight checks with the intent post v0.9.0
  • Updated the usage details form the changes in argument prompts

User experience

Users will not be able to specify the pre/post flight checks on the upgrade process.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +12.01 🎉

Comparison is base (c5e406b) 27.55% compared to head (1fea4c6) 39.56%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #114       +/-   ##
===========================================
+ Coverage   27.55%   39.56%   +12.01%     
===========================================
  Files          14       13        -1     
  Lines        1938     1337      -601     
===========================================
- Hits          534      529        -5     
+ Misses       1404      808      -596     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@quixoticmonk quixoticmonk marked this pull request as ready for review May 4, 2023 13:00
Copy link
Contributor

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

@mbeacom mbeacom merged commit dc76b67 into aws-samples:main May 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants