fix: Remove unnecessary use of tr in OpenSearch lab
#1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed that tr is used to mitigate enclosing quotes (") from the result of `aws ssm get-parameter`.
This might be destructive, because tr will remove *all* quotes, not only the enclosing ones and will not honor JSON escaped quotes.
Check:
`jq -cn '$ARGS.named' --arg test 'string_with"quotes"' | jq .test | tr -d '"'`
vs
`jq -cn '$ARGS.named' --arg test 'string_with"quotes"' | jq -r .test`
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks good, thanks @matschundbrei ! |
niallthomson
changed the title
tr in access-opensearch.mdtr in OpenSearch lab
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the unneccesary and potentially destructive use of
tr -d '"'to remove enclosing double-quotes from a json-string.Which issue(s) this PR fixes:
This might be destructive, because tr will remove all quotes, not only the enclosing ones and will not honor JSON escaped quotes.
Check:
jq -cn '$ARGS.named' --arg test 'string_with"quotes"' | jq .test | tr -d '"'vs
jq -cn '$ARGS.named' --arg test 'string_with"quotes"' | jq -r .testQuality checks
make test module="<module>"it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.