Skip to content

Update the imagePullPolicy to the correct value in configuration #48

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

albihasani94
Copy link

@albihasani94 albihasani94 commented Sep 30, 2019

  • values.yaml has declared the pullPolicy property
  • this value should be referred from the deployment as pullPolicy rather than imagePullPolicy

In values.yaml: pullPolicy

...
image:
  tag: latest
  pullPolicy: IfNotPresent

service:
  type: LoadBalancer
  externalPort: 80
  internalPort: 8080
  externalDebugPort: 5005
  internalDebugPort: 5005
...

In greeting-deployment.yaml: imagePullPolicy

...
spec:
      containers:
      - name: greeting
        image: {{ .Values.greeting.image }}:{{ .Values.image.tag }}
        imagePullPolicy: {{ .Values.image.imagePullPolicy }}
...

I have changed the property in greeting-deployment to:

imagePullPolicy: {{ .Values.image.pullPolicy }}

to correspond to the property declared in values.

- values.yaml has declared the pullPolicy property
- this value should be referred from the deployment as pullPolicy rather than imagePullPolicy
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant