Skip to content

push images to public ecr #116

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 7, 2021
Merged

push images to public ecr #116

merged 1 commit into from
Jan 7, 2021

Conversation

brycahta
Copy link
Contributor

@brycahta brycahta commented Jan 6, 2021

Issue #, if available:

  • We are not currently publishing images to public ECR

Description of changes:

  • Brought over Brandon's NTH ECR changes to AEMM
  • Added functionality to draft-release-notes to markdown the PR links for cross posting

Output of draft-release-notes:

  - push images to public ecr (thanks to Bryan™️)
  - make fmt [#113](https://github.com/aws/amazon-ec2-metadata-mock/pull/113) (thanks to Brandon Wagner)
  - remove CLA [#114](https://github.com/aws/amazon-ec2-metadata-mock/pull/114) (thanks to Brandon Wagner)
  - Update types.go [#112](https://github.com/aws/amazon-ec2-metadata-mock/pull/112) (thanks to Julian Martinez)
  - fix docker login commands for gh actions [#111](https://github.com/aws/amazon-ec2-metadata-mock/pull/111) (thanks to Brandon Wagner)
  - pr template [#110](https://github.com/aws/amazon-ec2-metadata-mock/pull/110) (thanks to Brandon Wagner)
  - gh actions [#109](https://github.com/aws/amazon-ec2-metadata-mock/pull/109) (thanks to Brandon Wagner)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from bwagner5 January 6, 2021 21:49
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the helm chart readme for the docker image repo too?

Everything else looks great!

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brycahta brycahta merged commit bbb3835 into aws:main Jan 7, 2021
@brycahta brycahta deleted the ecr-autom8 branch January 7, 2021 17:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants