Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support ECS specific fields that are not supported in compose #267

Closed
yinshiua opened this issue Jun 22, 2017 · 9 comments
Closed

Support ECS specific fields that are not supported in compose #267

yinshiua opened this issue Jun 22, 2017 · 9 comments
Assignees

Comments

@yinshiua
Copy link
Contributor

yinshiua commented Jun 22, 2017

ecs-cli compose does not support ECS specific parameters that are in compose including essential, Task role ARN, Network mode, etc.

@yinshiua
Copy link
Contributor Author

yinshiua commented Jun 23, 2017

Related to #153

@jonydev
Copy link

jonydev commented Jul 10, 2017

hi, @yinshiua. Is there any plan to provide the function of Network mode? We have a very strong demand on that.

@yinshiua
Copy link
Contributor Author

@jonydev Yes, we are planning on adding Network Mode into the CLI. We are working on putting together a proposal.

@qmcree
Copy link

qmcree commented Jul 14, 2017

+1... having the ability to mark containers as non-essential is really needed. Currently, the alternative of manually creating new task definitions is quite clunky.

@esetnik
Copy link

esetnik commented Aug 4, 2017

I second what @qmcree said. It's absolutely critical to be able to mark one-off task containers as non-essential.

@rbalicki2
Copy link

@qmcree could you go into more detail about your workaround? I'm new to using ecs-cli and am a bit confused.

@qmcree
Copy link

qmcree commented Aug 7, 2017

@rbalicki2 My solution is less than ideal. I used the ECS CLI to parse the Docker Compose YML as best it could to get the task definitions into ECS. Then, I manually configured the non-essential containers (like a worker we have) in the AWS console. For deployments, I fabfuel/ecs-deploy via Jenkins, which will parse a task definition in JSON, but will only change the Docker image tag. If we need to make changes to anything else in the definition like add/remove environment variables, we make them directly in the console. I look forward to when we can fully leverage Compose YML's via ECS CLI to make these changes.

@rbalicki2
Copy link

@qmcree Oh ok. So right now I have

/cargo/bin/diesel migration run

# https://github.com/aws/amazon-ecs-cli/issues/267
while true
do
  sleep 100000
done

I think that'll do until this is solved from the ecs-cli end...!

@qmcree
Copy link

qmcree commented Aug 7, 2017 via email

SoManyHs added a commit to SoManyHs/amazon-ecs-cli that referenced this issue Oct 11, 2017
Allows fields specific to an ECS TaskDefinition to be passed into compose
commands via a yaml file.

Closes aws#153.
Closes aws#188.
Addresses most of aws#267.
SoManyHs added a commit to SoManyHs/amazon-ecs-cli that referenced this issue Oct 19, 2017
SoManyHs added a commit to SoManyHs/amazon-ecs-cli that referenced this issue Oct 19, 2017
SoManyHs added a commit to SoManyHs/amazon-ecs-cli that referenced this issue Oct 19, 2017
SoManyHs added a commit to SoManyHs/amazon-ecs-cli that referenced this issue Oct 24, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

6 participants