Fix: Allow --trust-tools to work on MCP servers #2039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently if you call
--trust-tools
with tools that will be vended by MCP servers, the configuration doesn't take effect.Reproduction steps:
q chat --trust-tools=<tool>
(e.g.clear_thought___sequentialthinking
)/tools
to check trust statusDescription of changes:
This PR modifies the
ToolPermissions
implementation to track tools from the--trust-tools
config that don't exist yet, and triggers adding them topermissions
when they're available. It also configuresuntrust_tool
to modify this pending config as well aspermissions
, to avoid edge-cases where a tool can't be untrusted due to being in the pending list.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: Any opinions or communications in this pull request are entirely my own, and do not reflect those of AWS or its other employees.