iptables operation add timeout and retry exponentially #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yash97 may I ask for your help on how to unit test this implementation |
|
@yash97 I found out how to test. But the PR is quite big now, understand you dont prefer that |
phuhung273
changed the title
|
@yash97 want to know your thought on this PR |
|
@phuhung273 - I will review the PR and let you know. |
|
Thanks so much @orsenthil |
phuhung273
force-pushed
the
iptable-lock-logging
branch
from
3d08155 to
f424693
Compare
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix?:
Close #2945
What does this PR do / Why do we need it?:
Testing done on this change:
Will this PR introduce any new dependencies?:
Yes. retry util library: github.com/cenkalti/backoff/v4
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.