fix: Limitless plugin set round robin weights to original props used … #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchung-bitquill
force-pushed
the
fix/limitless-set-weight-props
branch
3 times, most recently
from
56d4c46 to
b2d9a1e
Compare
sergiyvamz
approved these changes
Dec 17, 2024
aaronchung-bitquill
force-pushed
the
fix/limitless-set-weight-props
branch
from
b2d9a1e to
663b335
Compare
…by the round robin host selector, not a copy
aaronchung-bitquill
force-pushed
the
fix/limitless-set-weight-props
branch
from
663b335 to
80b2dd4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by the round robin host selector, not a copy
Summary
Description
The RoundRobinHostSelector reads weights from the props from the plugin service. But the issue is that the Limitless plugin copies those props, setting the weights to its own copy of props which arent used by the RoundRobinHostSelector. So, the RoundRobinHostSelector will end up reading props without weights.
This fix makes it so that when the Limitless plugin sets the round robin host weights, it sets it to the props from plugin service, which are then read by the RoundRobinHostSelector.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.