-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
…ment (#31452) ### Issue # (if applicable) Closes #28579 ### Reason for this change The [CR lambda](https://github.com/aws/aws-cdk/blob/597228c1552a21f8dc7250a0be62160f838bb776/packages/%40aws-cdk/custom-resource-handlers/lib/aws-s3-deployment/bucket-deployment-handler/index.py#L138C14-L138C30) is essentially sending back the same data in the response which is hitting the limit for close to 50 object uploads. Particularly this is being a limitation when using servicecatalog.ProductStack, if there are local assets beyond a particular number, the Custom::CDKBucketDeployment would fail with the error Response object is too long which is a hard limit of 4096 bytes. ### Description of changes 1. Added a new property to control the custom resource sending large data and hitting the 4096 bytes limit even though the deployment operation is successful. 2. The property `outputObjectKeys` has been set to false by default for the service catalog product so that the error does not occur. ### Description of how you validated changes Validated using a sample stack with the property set and confirmed the behavior. Also, the existing deployments would be unaffected. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,16 @@ | ||
# Set the default behavior, in case people don't have core.autocrlf set. | ||
* text=auto | ||
|
||
# Currently, this repository has LF dependencies in building and testing, with json, sh, and no extensions. | ||
# Until this is fixed, it is best to just set the whole repository to be LF. | ||
* eol=lf | ||
|
||
*.gif binary | ||
*.zip binary | ||
*.png binary | ||
*.jpg binary | ||
*.tgz binary | ||
*.tar.gz binary | ||
|
||
# Hide snapshots from GitHub UI, except for the actual templates | ||
**/*.snapshot/** linguist-generated | ||
**/*.snapshot/**/*.template.json -linguist-generated | ||
**/*.snapshot/**/*DeployAssert*.template.json linguist-generated | ||
packages/@aws-cdk-testing/framework-integ/test/aws-s3-deployment/test/integ.bucket-deployment-big-response.js.snapshot/asset.3322b7049fb0ed2b7cbb644a2ada8d1116ff80c32dca89e6ada846b5de26f961.zip filter=lfs diff=lfs merge=lfs -text |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.