Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

(aws-ec2): Ability to enable "Detailed Monitoring" for EC2 instance #19346

Closed
1 of 2 tasks
Dzhuneyt opened this issue Mar 11, 2022 · 3 comments · Fixed by #19437
Closed
1 of 2 tasks

(aws-ec2): Ability to enable "Detailed Monitoring" for EC2 instance #19346

Dzhuneyt opened this issue Mar 11, 2022 · 3 comments · Fixed by #19437
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@Dzhuneyt
Copy link
Contributor

Description

The current ec2.Instance() construct does not expose the "monitoring" prop that the underlying CfnInstance does.

Use Case

I want to create EC2 instances with Detailed Monitoring enabled.

Proposed Solution

new ec2.Instance(this, 'Instance', {
   ...
   monitoring: true|false,
   ...
});

Other information

https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-ec2/lib/instance.ts#L371

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@Dzhuneyt Dzhuneyt added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 11, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Mar 11, 2022
@corymhall corymhall added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 11, 2022
@corymhall
Copy link
Contributor

I am unassigning and marking this issue as p2, which means that we are unable to work on this immediately, but contributions are definitely welcome.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

@Dzhuneyt
Copy link
Contributor Author

@corymhall I've tried to solve this with the above PR. Let me know if you have any concerns.

@mergify mergify bot closed this as completed in #19437 Mar 29, 2022
mergify bot pushed a commit that referenced this issue Mar 29, 2022
Closes #19346

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
Closes aws#19346

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants