Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[aws-batch] missing launchTemplateId in LaunchTemplateSpecification #20163

Closed
2 tasks
AlJohri opened this issue May 2, 2022 · 2 comments · Fixed by #20184
Closed
2 tasks

[aws-batch] missing launchTemplateId in LaunchTemplateSpecification #20163

AlJohri opened this issue May 2, 2022 · 2 comments · Fixed by #20184
Assignees
Labels
@aws-cdk/aws-batch Related to AWS Batch feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@AlJohri
Copy link

AlJohri commented May 2, 2022

Describe the feature

Add support for launchTemplateId when attaching a launchTemplate to a Batch Compute environment. Currently it requires using a launchTemplateName.

new batch.ComputeEnvironment(this, 'ComputeEnv', {
  computeResources: {
    launchTemplate: {
      launchTemplateName: myLaunchTemplate.launchTemplateName as string, //or simply use an existing template name
    },
    vpc,
  }
});

This should be supported: https://docs.aws.amazon.com/batch/latest/APIReference/API_LaunchTemplateSpecification.html

Use Case

I would like to stop naming resources explicitly as per CDK best practice and let CDK handle naming the launch template.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

1.153.1

Environment details (OS name and version, etc.)

Amazon Linux 2

@AlJohri AlJohri added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 2, 2022
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label May 2, 2022
@indrora
Copy link
Contributor

indrora commented Jun 28, 2022

@TheRealAmazonKendra @madeline-k Looks like there's a PR that addresses this. Can we get review on that?

@peterwoodworth peterwoodworth added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 29, 2022
@mergify mergify bot closed this as completed in #20184 Jul 7, 2022
mergify bot pushed a commit that referenced this issue Jul 7, 2022
)

Closes #20163

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

daschaa pushed a commit to daschaa/aws-cdk that referenced this issue Jul 9, 2022
…#20184)

Closes aws#20163

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
@aws-cdk/aws-batch Related to AWS Batch feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants