Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

(neptune): add engine version 1.1.1.0 #20869

Closed
1 of 2 tasks
adamlbo opened this issue Jun 25, 2022 · 3 comments · Fixed by #21079
Closed
1 of 2 tasks

(neptune): add engine version 1.1.1.0 #20869

adamlbo opened this issue Jun 25, 2022 · 3 comments · Fixed by #21079
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@adamlbo
Copy link

adamlbo commented Jun 25, 2022

Describe the feature

Add new Neptune engine version 1.1.1.0
https://docs.aws.amazon.com/neptune/latest/userguide/doc-history.html

Use Case

Support for Gremlin version: 3.5.2

Proposed Solution

Similar to this PR - #17669

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.29.1

Environment details (OS name and version, etc.)

macOS
@adamlbo adamlbo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 25, 2022
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Jun 25, 2022
@kaizencc kaizencc added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 28, 2022
@kaizencc kaizencc removed their assignment Jun 28, 2022
@kaizencc kaizencc changed the title feat(aws-neptune): add engine version 1.1.1.0 neptune: add engine version 1.1.1.0 Jun 28, 2022
@kaizencc kaizencc changed the title neptune: add engine version 1.1.1.0 (neptune): add engine version 1.1.1.0 Jun 28, 2022
@jumic
Copy link
Contributor

jumic commented Jul 1, 2022 •
edited
Loading

@adamlbo Will you add the new version yourself and create a pull request? (You have selected option "I may be able to implement this feature request").

If you want someone else to add the new version, write a short comment here.

@adamlbo
Copy link
Author

adamlbo commented Jul 1, 2022

Hi @jumic! I had planned on reviewing the contribution docs this weekend and creating a PR.

@daschaa daschaa mentioned this issue Jul 10, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #21079 Jul 11, 2022
mergify bot pushed a commit that referenced this issue Jul 11, 2022
@daschaa
feat(neptune): add engine version 1.1.1.0 (#21079)
a113816 
Fixes #20869.

Adds new engine version `1.1.1.0` to Neptune.
See https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases.html

As this is just  a new enum value, it would be great if the label `pr-linter/exempt-readme` and `pr-linter/exempt-integ-test` could be added. Thanks!

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(neptune): add engine version 1.1.1.0 daschaa/aws-cdk
3 participants
@jumic @adamlbo @kaizencc