Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

RDS: DatabaseCluster Instance Identifiers Attribute #25947

Closed
2 tasks
argarinpauljohn opened this issue Jun 13, 2023 · 3 comments · Fixed by #26929
Closed
2 tasks

RDS: DatabaseCluster Instance Identifiers Attribute #25947

argarinpauljohn opened this issue Jun 13, 2023 · 3 comments · Fixed by #26929
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@argarinpauljohn
Copy link

argarinpauljohn commented Jun 13, 2023 •
edited
Loading

Describe the feature

In the new writer/reader API, only readers' IDs are returned: aws-cdk/packages/aws-cdk-lib/aws-rds/lib/cluster.ts

Related issue: #25898

Use Case

We need the writer's instance ID to subscribe to its events.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.82.0

Environment details (OS name and version, etc.)

macOS Ventura 13.3.1
@argarinpauljohn argarinpauljohn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 13, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Jun 13, 2023
@peterwoodworth
Copy link
Contributor

Makes sense to return the writer ID here as well as the reader ID. I think this should only take a one liner which pushes the writer.instanceIdentifier to instanceIdentifiers.

aws-cdk/packages/aws-cdk-lib/aws-rds/lib/cluster.ts

Line 666 in 006b542

instanceIdentifiers,

@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 13, 2023
@argarinpauljohn argarinpauljohn mentioned this issue Jun 13, 2023
Closed
@peterwoodworth peterwoodworth mentioned this issue Jul 5, 2023
Closed
2 tasks
This was referenced Jul 26, 2023
Closed
Closed
@vincent-dm
Copy link

Is anyone working on this?

@kirkwat kirkwat mentioned this issue Aug 30, 2023
Merged
@mergify mergify bot closed this as completed in #26929 Sep 19, 2023
mergify bot pushed a commit that referenced this issue Sep 19, 2023
@kirkwat
fix(rds): cluster.instanceIdentifiers does not container writer insta…
d3789ab 
…nce ID (#26929)

Cluster writer instance ID is now returned in instanceIdentifiers with reader instance IDs.

Closes #25947.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

HBobertz pushed a commit that referenced this issue Sep 19, 2023
@kirkwat
fix(rds): cluster.instanceIdentifiers does not container writer insta…
296acc9 
…nce ID (#26929)

Cluster writer instance ID is now returned in instanceIdentifiers with reader instance IDs.

Closes #25947.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
3 participants
@vincent-dm @peterwoodworth @argarinpauljohn