Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

s3 LifecycleRule.ExpirationDate: due to changes in CFN validation last week - template format is broken #28065

Closed
raziza opened this issue Nov 19, 2023 · 3 comments · Fixed by #28149
Labels
@aws-cdk/aws-s3 Related to Amazon S3 bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@raziza
Copy link

raziza commented Nov 19, 2023

Describe the bug

Since last week our template failed to deploy. After talking to AWS customer services seems that last week a strict validation was forced now on this field. which leads the CDK output template to fail.

today the output results this text

"ExpirationDate": "2024-11-19T00:00:00"

as understood from the customer services - Z must be added in the end.

our code is doing so:
lifecycleMaxSizeRuleBuilder.expirationDate(LocalDate.now().plus(1, ChronoUnit.YEARS).atStartOfDay().toInstant(ZoneOffset.UTC));

Expected Behavior

With Z in the end
"ExpirationDate": "2024-11-19T00:00:00Z"

Current Behavior

"ExpirationDate": "2024-11-19T00:00:00"

Reproduction Steps

simply synth

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.109.0

Framework Version

No response

Node.js Version

16.13.1

OS

Win 10

Language

Java

Language Version

No response

Other information

No response

@raziza raziza added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2023
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Nov 19, 2023
@msambol
Copy link
Contributor

msambol commented Nov 20, 2023

I'll take this. Can confirm here there is a Z on the end of the pattern.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 21, 2023
@pahud
Copy link
Contributor

pahud commented Nov 21, 2023

Sounds like a cloudformation validation error? Yes, we should add a trailing Z if it's necessary.

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants