Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

aws_stepfunctions_tasks: Implement StartBuildBatch #29119

Closed
2 tasks
JonathanWoollett-Light opened this issue Feb 15, 2024 · 3 comments · Fixed by #29296
Closed
2 tasks

aws_stepfunctions_tasks: Implement StartBuildBatch #29119

JonathanWoollett-Light opened this issue Feb 15, 2024 · 3 comments · Fixed by #29296
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@JonathanWoollett-Light
Copy link

JonathanWoollett-Light commented Feb 15, 2024 •
edited
Loading

Describe the feature

Only https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_stepfunctions_tasks-readme.html#startbuild is currently supported this makes integration with other services difficult.

One of the other most significant functions is https://docs.aws.amazon.com/codebuild/latest/APIReference/API_StartBuildBatch.html, this should be supported.

It seems arbitrary to support only 1 or a small subset function in CDKs rather than the full set.

Use Case

I want to run start a build for a batch task in codebuild.

Proposed Solution

Implement https://docs.aws.amazon.com/codebuild/latest/APIReference/API_StartBuildBatch.html the same as https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_stepfunctions_tasks-readme.html#startbuild.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.128.0

Environment details (OS name and version, etc.)

5.10, Amazon Linux 2, x86-64
@JonathanWoollett-Light JonathanWoollett-Light added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2024
@tim-finnigan tim-finnigan self-assigned this Feb 15, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 15, 2024
@tim-finnigan
Copy link

Thanks for the feature request, it seems like this would be useful. Directory for reference: https://github.com/aws/aws-cdk/tree/main/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/codebuild

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Feb 15, 2024
@tim-finnigan tim-finnigan removed their assignment Feb 15, 2024
@JonathanWoollett-Light
Copy link
Author

Related discussion #29120

@badmintoncryer badmintoncryer mentioned this issue Feb 28, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Mar 1, 2024
Closed
@mergify mergify bot closed this as completed in #29296 Mar 7, 2024
mergify bot pushed a commit that referenced this issue Mar 7, 2024
@badmintoncryer
feat(stepfunctions-tasks): start build batch integration (#29296)
4f2b757 
### Issue # (if applicable)

Closes #29119.

### Reason for this change

There is an optimized integration with codebuild but it is not able to integrate by AWS CDK.

### Description of changes

Add CodeBuildStartBuildBatch class

```ts
declare const project: codebuild.Project;

const buildconfig = project.enableBatchBuilds();

const startBuildBatch = new tasks.CodeBuildStartBuildBatch(this, 'buildTask', {
      project,
      integrationPattern: sfn.IntegrationPattern.REQUEST_RESPONSE,
      environmentVariablesOverride: {
        test: {
          type: codebuild.BuildEnvironmentVariableType.PLAINTEXT,
          value: 'testValue',
        },
      },
});
```

### Description of how you validated changes

I've implemented both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions-tasks): start build batch integration badmintoncryer/aws-cdk
2 participants
@JonathanWoollett-Light @tim-finnigan