Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

rds: support for IO2 instance storage #29396

Closed
1 of 2 tasks
badmintoncryer opened this issue Mar 7, 2024 · 2 comments · Fixed by #29395
Closed
1 of 2 tasks

rds: support for IO2 instance storage #29396

badmintoncryer opened this issue Mar 7, 2024 · 2 comments · Fixed by #29395
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Support for IO2 instance storage type.

https://aws.amazon.com/jp/blogs/aws/amazon-rds-now-supports-io2-block-express-volumes-for-mission-critical-database-workloads/

Use Case

AWS CDK cannot configure IO2 storage type for RDS instance .

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.131.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 7, 2024
@badmintoncryer badmintoncryer mentioned this issue Mar 7, 2024
Merged
1 task
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Mar 7, 2024
@pahud
Copy link
Contributor

pahud commented Mar 7, 2024

Yes I guess we should add the support in the enum. Thank you for your PR!

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 7, 2024
@mergify mergify bot closed this as completed in #29395 Mar 8, 2024
mergify bot pushed a commit that referenced this issue Mar 8, 2024
@badmintoncryer
chore(rds): IO2 instance storage (#29395)
8b0dbb7 
### Issue # (if applicable)

Closes #29396.

### Reason for this change

[AWS RDS now supports IO2 instance storage](https://aws.amazon.com/jp/blogs/aws/amazon-rds-now-supports-io2-block-express-volumes-for-mission-critical-database-workloads/) but CDK cannot configure it yet.

### Description of changes

- Added IO2 storage type to the `StorageType` enum.
- Set default IOPS to 1000, which is minimum value in the allowed IOPS range.

### Description of how you validated changes

Added both unit and integ test

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rds): IO2 instance storage badmintoncryer/aws-cdk
2 participants
@pahud @badmintoncryer