Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

elasticloadbalancingv2: support NLB attributes #29520

Closed
1 of 2 tasks
badmintoncryer opened this issue Mar 17, 2024 · 2 comments · Fixed by #29521 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Closed
1 of 2 tasks

elasticloadbalancingv2: support NLB attributes #29520

badmintoncryer opened this issue Mar 17, 2024 · 2 comments · Fixed by #29521 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

We can configure NLB attributes from AWS CDK.

  • ipv6.deny_all_igw_traffic
  • dns_record.client_routing_policy

Use Case

NLB supports these attributes but they are not be configurable by AWS CDK.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.132.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2024
@badmintoncryer badmintoncryer changed the title (module name): (short issue description) elasticloadbalancingv2: support NLB attributes Mar 17, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Mar 17, 2024
@badmintoncryer badmintoncryer mentioned this issue Mar 17, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Mar 18, 2024
Closed
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 18, 2024
@tim-finnigan
Copy link

Thanks for the feature request and creating that PR!

@tim-finnigan tim-finnigan added p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 18, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 18, 2024
GavinZZ added a commit that referenced this issue Mar 19, 2024
@badmintoncryer @GavinZZ
feat(elasticloadbalancingv2): denyAllIgwTraffic and `clientRoutingP…
7fe8ad3 
…olicy` for NLB (#29521)

### Issue # (if applicable)

Closes #29520.

### Reason for this change

NLB supports `ipv6.deny_all_igw_traffic` and
`dns_record.client_routing_policy` but these are not configurable from
AWS CDK.

### Description of changes

- add `zonalAffinity` props to `NetworkLoadBalancerProps`
- add `denyAllIgwTraffic` props to `BaseLoadBalancerProps`
  - `ipv6.deny_all_igw_traffic` is also supported by ALB

### Description of how you validated changes

I've added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

---------

Co-authored-by: GZ <yuanhaoz@amazon.com>
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

ahammond pushed a commit to ahammond/aws-cdk that referenced this issue Mar 26, 2024
@badmintoncryer @GavinZZ @ahammond
feat(elasticloadbalancingv2): denyAllIgwTraffic and `clientRoutingP…
2a6d8ad 
…olicy` for NLB (aws#29521)

### Issue # (if applicable)

Closes aws#29520.

### Reason for this change

NLB supports `ipv6.deny_all_igw_traffic` and
`dns_record.client_routing_policy` but these are not configurable from
AWS CDK.

### Description of changes

- add `zonalAffinity` props to `NetworkLoadBalancerProps`
- add `denyAllIgwTraffic` props to `BaseLoadBalancerProps`
  - `ipv6.deny_all_igw_traffic` is also supported by ALB

### Description of how you validated changes

I've added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING
GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and
[DESIGN
GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*

---------

Co-authored-by: GZ <yuanhaoz@amazon.com>
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
@Michae1CC Michae1CC mentioned this issue Apr 25, 2024
Merged
1 task
This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this issue May 30, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@badmintoncryer @tim-finnigan @khushail