Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

aws_cognito: UserPoolIdentityProviderOidc doesn't support SecretValue for client secret #29851

Open
1 of 2 tasks
guillaume-mindflow opened this issue Apr 16, 2024 · 1 comment
Open
1 of 2 tasks

aws_cognito: UserPoolIdentityProviderOidc doesn't support SecretValue for client secret #29851

guillaume-mindflow opened this issue Apr 16, 2024 · 1 comment
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@guillaume-mindflow
Copy link

Describe the feature

Hello,

Small FR that would make the use of SecretValue more straightforward.

UserPoolIdentityProviderOidc needs a client secret value for deployment. As of now it only supports string value.
Compared to the generic one like UserPoolIdentityProviderGoogle who support clientSecretValue.

Use Case

It would make the DX a bit better, simplifying the resolution. And also align with the other providers from the cognito package.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.131.0

Environment details (OS name and version, etc.)

MacOS
@guillaume-mindflow guillaume-mindflow added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Apr 16, 2024
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2024
@khushail
Copy link
Contributor

thanks @guillaume-mindflow for volunteering for PR contrinbution.

This was referenced Apr 22, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue May 1, 2024
Closed
jwoehrle pushed a commit to jwoehrle/aws-cdk that referenced this issue May 7, 2024
feat: Support SecretValue for UserPoolIdentityProviderOidc. Fixes aws…
6a568c5 
…#29851
@jwoehrle jwoehrle mentioned this issue May 7, 2024
Closed
1 task
@github-actions github-actions bot mentioned this issue May 13, 2024
Closed
jwoehrle pushed a commit to jwoehrle/aws-cdk that referenced this issue May 17, 2024
chore: Support SecretValue for UserPoolIdentityProviderOidc. Fixes aw…
2dc43d9 
…s#29851
@jwoehrle jwoehrle mentioned this issue May 17, 2024
Closed
1 task
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
3 participants
@pahud @khushail @guillaume-mindflow