Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

eks: typo in code doc #30613

Closed
richardgroves opened this issue Jun 21, 2024 · 3 comments · Fixed by #30614
Closed

eks: typo in code doc #30613

richardgroves opened this issue Jun 21, 2024 · 3 comments · Fixed by #30614
Assignees
@ashishdhingra
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2

Comments

@richardgroves
Copy link

Describe the issue

KubectlV29Layer should be KubectlV30Layer in the code doc.

aws-cdk/packages/aws-cdk-lib/aws-eks/lib/cluster.ts

Line 973 in 8b495f9

* `kubectlLayer` property with a `KubectlV29Layer` from

Links

aws-cdk/packages/aws-cdk-lib/aws-eks/lib/cluster.ts

Line 973 in 8b495f9

* `kubectlLayer` property with a `KubectlV29Layer` from

@richardgroves richardgroves added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2024
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Jun 21, 2024
@ashishdhingra ashishdhingra self-assigned this Jun 21, 2024
@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2024
@ashishdhingra
Copy link
Contributor

Yes, this appears to be documentation issue.

@ashishdhingra ashishdhingra mentioned this issue Jun 21, 2024
Merged
1 task
mergify bot pushed a commit that referenced this issue Jun 21, 2024
@ashishdhingra
docs(eks): corrected documentation for KubernetesVersion.V1_30 proper…
d1d217f 
…ty (#30614)

### Issue # (if applicable)
Closes #30613.

### Reason for this change
Documentation for `KubernetesVersion.V1_30` property incorrectly refers to `KubectlV29Layer`.


### Description of changes
Corrected documentation for KubernetesVersion.V1_30 property to refer to `KubectlV30Layer`.

### Description of how you validated changes
N/A
### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mergify mergify bot closed this as completed in #30614 Jun 21, 2024
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Jun 24, 2024
Closed
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@ashishdhingra ashishdhingra

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(eks): corrected documentation for KubernetesVersion.V1_30 property aws/aws-cdk
3 participants
@richardgroves @aws-cdk-automation @ashishdhingra