Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

aws-synthetics: support syn-nodejs-puppeteer-8.0 runtime #30850

Closed
2 tasks
jwilson-anonyome opened this issue Jul 14, 2024 · 3 comments · Fixed by #30851
Closed
2 tasks

aws-synthetics: support syn-nodejs-puppeteer-8.0 runtime #30850

jwilson-anonyome opened this issue Jul 14, 2024 · 3 comments · Fixed by #30851
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@jwilson-anonyome
Copy link

Describe the feature

https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html confirms that Synthetics runtime "syn-nodejs-puppeteer-8.0" is available.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts only has up to 7.0

Can we support this in CDK please? Thanks.

Use Case

Need to be able to use latest runtimes

Proposed Solution

Update aws-cdk-lib/aws-synthetics/lib/runtime.ts

Other Information

Previous PR for runtime updating: #29446

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.148.0

Environment details (OS name and version, etc.)

n/a
@jwilson-anonyome jwilson-anonyome added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 14, 2024
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Jul 14, 2024
@jwilson-anonyome jwilson-anonyome changed the title (module name): (short issue description) aws-synthetics: support syn-nodejs-puppeteer-8.0 runtime Jul 14, 2024
@mazyu36 mazyu36 mentioned this issue Jul 15, 2024
Merged
1 task
This was referenced Jul 15, 2024
Closed
Closed
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 15, 2024
@ashishdhingra ashishdhingra self-assigned this Jul 15, 2024
@ashishdhingra
Copy link
Contributor

Indeed, syn-nodejs-puppeteer-8.0 is the newest version supported. Below screenshot from AWS CloudWatch console also confirms the same:
Screenshot 2024-07-15 at 10 09 42 AM

@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 15, 2024
@ashishdhingra ashishdhingra removed their assignment Jul 15, 2024
@mergify mergify bot closed this as completed in #30851 Jul 18, 2024
mergify bot pushed a commit that referenced this issue Jul 18, 2024
@mazyu36
chore(synthetics): add nodejs puppeteer 8 runtime (#30851)
bbf1ad4 
### Issue # (if applicable)

Closes #30850.

### Reason for this change

Add new runtime

https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_nodejs_puppeteer.html#CloudWatch_Synthetics_runtimeversion-nodejs-puppeteer-8.0

### Description of changes

Add new runtime



### Description of how you validated changes

No test added because just add runtime enum.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(synthetics): add nodejs puppeteer 8 runtime mazyu36/aws-cdk
3 participants
@aws-cdk-automation @ashishdhingra @jwilson-anonyome