Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

kms: Add support for KEY_AGREEMENT to KeyUsage in KMS key #30989

Closed
2 tasks
lohn opened this issue Jul 31, 2024 · 3 comments · Fixed by #30993
Closed
2 tasks

kms: Add support for KEY_AGREEMENT to KeyUsage in KMS key #30989

lohn opened this issue Jul 31, 2024 · 3 comments · Fixed by #30993
Labels
@aws-cdk/aws-kms Related to AWS Key Management effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@lohn
Copy link

lohn commented Jul 31, 2024

Describe the feature

Add support for KEY_AGREEMENT to KeyUsage when creating KMS keys.

Use Case

To create KMS keys for shared secret derivation using CDK, enabling the use of the new DeriveSharedSecret API.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.150.0

Environment details (OS name and version, etc.)

macOS Sonoma 14.5
@lohn lohn added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 31, 2024
@github-actions github-actions bot added the @aws-cdk/aws-kms Related to AWS Key Management label Jul 31, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 31, 2024
@khushail
Copy link
Contributor

khushail commented Jul 31, 2024 •
edited
Loading

Hi @lohn , thanks for requesting this. I see this is supported by Cloudformation - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-kms-key.html#cfn-kms-key-keyusage, so CDK is good to provide support for the requested feature-

aws-cdk/packages/aws-cdk-lib/aws-kms/lib/key.ts

Line 392 in 3f93027

export enum KeyUsage {

Marking this as P3 for the contribution from the community.

@khushail khushail added effort/small Small work item – less than a day of effort p3 and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 labels Jul 31, 2024
@mazyu36 mazyu36 mentioned this issue Jul 31, 2024
Merged
1 task
This was referenced Aug 1, 2024
Closed
Closed
Closed
@mergify mergify bot closed this as completed in #30993 Nov 8, 2024
@mergify mergify bot closed this as completed in 2323877 Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this issue Nov 13, 2024
@mazyu36
feat(kms): support KEY_AGREEMENT for keyUsage (aws#30993)
946d6a9 
### Issue # (if applicable)

Closes aws#30989

### Reason for this change
To support `KEY_AGREEMENT` for KeyUsage.


### Description of changes
* Add `KEY_AGREEMENT` to KeyUsage enum
* Add validation rule



### Description of how you validated changes
Add unit test and integ test.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
@aws-cdk/aws-kms Related to AWS Key Management effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(kms): support KEY_AGREEMENT for keyUsage mazyu36/aws-cdk
2 participants
@lohn @khushail