Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(rds): unable to create cluster with per-instance parameters (under feature flag) #27040

Merged
merged 7 commits into from
Sep 22, 2023
Merged

fix(rds): unable to create cluster with per-instance parameters (under feature flag) #27040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d7fd72
fix(rds): Cannot create multiple readers with each parameters
go-to-k Sep 7, 2023
7beacaa
test: change an unit test
go-to-k Sep 7, 2023
f83e4d2
fix for the review
go-to-k Sep 19, 2023
ee428c5
feature flag without integ tests
go-to-k Sep 20, 2023
8089170
change unit test for feature flag
go-to-k Sep 20, 2023
c973b5f
change integ tests
go-to-k Sep 20, 2023
138b3eb
Merge branch 'main' into fix/with-multiple-readers-with-each-parameters
rix0rrr Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ...st/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ-with-feature-flag.assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"version": "34.0.0",
"files": {
"6ef7bb16723c1bb9cf7146bc933297a5225c070c914722f051953fcd6623a3f3": {
"source": {
"path": "aws-cdk-rds-integ-with-feature-flag.template.json",
"packaging": "file"
},
"destinations": {
"current_account-current_region": {
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}",
"objectKey": "6ef7bb16723c1bb9cf7146bc933297a5225c070c914722f051953fcd6623a3f3.json",
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}"
}
}
}
},
"dockerImages": {}
}
Loading