fix(CLI): change-set diff not required for new stack diffs #29268
Conversation
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Signed-off-by: Sumu <sumughan@amazon.com>
sumupitchayan
added
the
pr-linter/exempt-integ-test
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Signed-off-by: Sumu <sumughan@amazon.com>
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
sumupitchayan
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
aws-cdk-automation
added
the
pr/needs-maintainer-review
| @@ -1231,4 +1231,22 @@ describe('changeset', () => { | |||
| expect(differences.resources.differenceCount).toBe(1); | |||
| expect(differences.resources.get('BucketResource').changeImpact === ResourceImpact.WILL_IMPORT); | |||
| }); | |||
|
|
|||
| test('does not do changeset checks for new stack', async () => { | |||
There was a problem hiding this comment.
I might be missing something but I'm not sure how this tests that we do not do a changeset for new stacks. Could you clarify that?
There was a problem hiding this comment.
Was confused on this too - my logic was that calling fullDiff with the current stack being empty (new) should mean that there should be only 1 difference count, and the change impact should be ResourceImpact.WILL_CREATE; I'm not sure how else to test that we don't do changeset for new stacks
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
…com/aws/aws-cdk into sumughan/fix-changeset-delete-stack
sumupitchayan
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
…ives for migrate Signed-off-by: Sumu <sumughan@amazon.com>
This reverts commit bcb544c.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Closed by #29394. |
Closes #29265
Adds a check in the
fullDifffunction to make sure that change-set diff is not run for new stack diffs.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license