chore(rds): update engine versions #29422

nmussy · 2024-03-09T20:07:58Z

Issue # (if applicable)

Note: #29421 already adds some of the missing Oracle versions, this PR also includes them

Reason for this change

Update the CDK RDS engine versions to match the current availability, as well as facilitate automated alerts for updates in the future

Description of changes

Added missing engine version for all RDS engines
- This includes engines missing in the CDK that are already deprecated, but still returned by the SDK. The goal is to remove any differences between the two, even if it means a few needless static fields
Updated missing or un-needed @deprecated TSDoc tags

Description of how you validated changes

Like I mentioned in #29360 (comment), I'm working on a CLI that compares the aws-cdk-lib TypeScript declarations to SDK API calls, in this case DescribeDBEngineVersions.
I am re-validating these locally edited files as I update them, until I have no differences between the CDK and the live SDK results.

This is currently a mostly manual process. I'll add support for more version fields such as ec2.WindowsVersion before adding automation, to bridge the other currently missing versions ASAP.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

msambol · 2024-03-10T15:57:53Z

packages/aws-cdk-lib/aws-rds/lib/cluster-engine.ts

-   *  Version "14.4".
-   * @deprecated Version 14.4 is no longer supported by Amazon RDS.
-   */
+  /**  Version "14.4". */


Was this wrongly deprecated previously?

I would assume so, unless it was deprecated then reinstated?

$ aws rds describe-db-engine-versions --engine aurora-postgresql --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion=="14.4") | .Status' available $ aws rds describe-db-engine-versions --engine aurora-postgresql --region eu-west-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion=="14.4") | .Status' available

EDIT: Fixed version in jq filter

msambol

LGTM. I'm interested in the tool you're developing for automating this.

nmussy · 2024-03-10T16:35:25Z

@msambol It's very messy ATM, just a collection of loose scripts I'm running manually. Once I'm done opening PRs here I'll give it a once over, add a CLI and make the repo public 👍

The end goal is probably to have the tool run daily, and open/update GitHub issues if there are any drifts with master, with basic code recommendations. Having it automate PRs would be ideal but I'm sure there will be difficulties automating everything, e.g. generating symbolic values for ec2.InstanceClass

lpizzinidev

Thanks 👍
I left some notes as I found some inconsistencies between the changes and the AWS documentation. Not sure if the documentation is outdated.

lpizzinidev · 2024-03-10T16:12:54Z

packages/aws-cdk-lib/aws-rds/lib/cluster-engine.ts

+  /**
+   * Version "11.16"
+   * @deprecated Version 11.16 is no longer supported by Amazon RDS.
+   */
  public static readonly VER_11_16 = AuroraPostgresEngineVersion.of('11.16', '11', { s3Import: true, s3Export: true });


Docs mark Aurora PostgreSQL v11 deprecated up to 11.15.
Did you check a different source?

The docs would also be out of date then, I'm using the SDK for reference. In this case, it's not even listed. Here is the CLI command:

$ aws rds describe-db-engine-versions --engine aurora-postgresql --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion=="11.16")'

lpizzinidev · 2024-03-10T16:14:28Z

packages/aws-cdk-lib/aws-rds/lib/cluster-engine.ts

+  * Version "5.7.mysql_aurora.2.05.1"
+  * @deprecated Version 5.7.mysql_aurora.2.05.1 is no longer supported by Amazon RDS.
+  */
+  public static readonly VER_2_05_1 = AuroraMysqlEngineVersion.builtIn_5_7('2.05.1');


Cannot find this version in the release notes.

Again, based on the SDK, it's not listed. It could have been removed, or never existed:

$ aws rds describe-db-engine-versions --engine aurora-mysql --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion | endswith("2.05.1"))'

lpizzinidev · 2024-03-10T16:24:33Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

+  /**
+   * Version "12.00.6293.0.v1".
+   * @deprecated SQL Server 12.00.6293.0.v1 is no longer supported by Amazon RDS.
+   */
  public static readonly VER_12_00_6293_0_V1 = SqlServerEngineVersion.of('12.00.6293.0.v1', '12.00');


12.00.6293.0.v1 and above seem still supported from docs.

Again, not listed by the SDK:

$ aws rds describe-db-engine-versions --engine sqlserver-se --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion | startswith("12."))' $ aws rds describe-db-engine-versions --engine sqlserver-ee --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion | startswith("12."))' $ aws rds describe-db-engine-versions --engine sqlserver-ex --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion | startswith("12."))' $ aws rds describe-db-engine-versions --engine sqlserver-web --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion | startswith("12."))'

lpizzinidev · 2024-03-10T16:29:08Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

+  /**
+   * Version "5.7.36"
+   * @deprecated MySQL 5.7.36 is no longer supported by Amazon RDS.
+   */


It seems like v5 is now deprecated (docs)

Again, based on the SDK:

$ aws rds describe-db-engine-versions --engine mysql --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion | startswith("5.")) | .EngineVersion,.Status' 5.7.37 available 5.7.38 available 5.7.39 available 5.7.40 available 5.7.41 available 5.7.42 available 5.7.43 available 5.7.44 available

lpizzinidev · 2024-03-10T16:31:12Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

-  /** Version "11.16". */
+  /**
+   * Version "11.16"
+   * @deprecated PostgreSQL 11.16 is no longer supported by Amazon RDS.


It seems like v11 is now deprecated (docs)

Again, based on the SDK:

$ aws rds describe-db-engine-versions --engine postgres --region us-east-1 | jq -r '.DBEngineVersions[] | select(.EngineVersion | startswith("11.")) | .EngineVersion,.Status' 11.17 available 11.18 available 11.19 available 11.20 available 11.21 available 11.22 available

lpizzinidev · 2024-03-10T16:35:16Z

packages/aws-cdk-lib/aws-rds/lib/instance-engine.ts

@@ -1841,67 +2249,159 @@ class OracleEeCdbInstanceEngine extends OracleInstanceEngineBase {
 * and `DatabaseInstanceEngine.sqlServerEe`).


Suggested change

* and `DatabaseInstanceEngine.sqlServerEe`).

* and `DatabaseInstanceEngine.sqlServerEe`).

*

* @see https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/CHAP_SQLServer.html#SQLServer.Concepts.General.VersionSupport

I think it would be useful to add links in the documentation for each class showing the version notes for each instance and cluster engine.

Seen as the documentation doesn't seem to match the live data, it might be confusing, not sure about this

Yup, that's confusing indeed. I guess we should trust the API.
Thanks for the detailed clarification 👍

paulhcsun

Nice work @nmussy! Looking forward to the completed version of your tool, it'll be super helpful!

Thanks for the review @msambol @lpizzinidev!

aws-cdk-automation · 2024-03-11T16:54:51Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: ea20b85
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-03-11T17:27:53Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

### Issue # (if applicable) Closes #23854 ### Reason for this change Update the CDK EC2 instance class and size enums to match the current availability ### Description of changes Added the missing instance class and sizes ### Description of how you validated changes This was generated with the help of the same tool I used to create #29422, using the live SDK data to match against the CDK. For the instance types, I am using the `DescribeInstanceTypes` API command in multiple regions (`us-east-1`, `us-east-2`, `us-west-1`, `eu-west-1`.) As far as I could tell, the union of `us-east-1` and `us-east-2` cover all possible instance classes and sizes, but correct me if I'm wrong. As a sanity check, I'm also checking that the CDK does not have more instance types and sizes that the SDK does. It does vary between regions, but of note, there were: * `p4de`, in developer preview * `x2g`, RDS exclusive and not returned by `DescribeInstanceTypes` Finally, I am ignoring some of the previous generation instance classes missing from the CDK, as they are very outdated and weren't added in first place, i.e. `c1`, `t1`, `m1`, `m2`, and `i2`. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

### Issue # (if applicable) None ### Reason for this change Update the CDK RDS engine versions to match the current availability, as well as facilitate automated alerts for updates in the future ### Description of changes * Added missing engine version for all RDS engines * Added missing `@deprecated` TSDoc tags ### Description of how you validated changes The available versions were compared to live AWS API data. See #29422 for more details. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

nmussy added 7 commits March 9, 2024 18:25

chore(rds): update MySQL engine versions

d8f126f

chore(rds): update Postgres engine versions

a53aa43

chore(rds): update MariaDB engine versions

a30fdfc

chore(rds): update Oracle engine versions

b83ed11

chore(rds): update SqlServer engine versions

36397dc

chore(rds): update AuroraMysql engine versions

2b82464

chore(rds): update AuroraPostgres engine versions

cde4d5b

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Mar 9, 2024

aws-cdk-automation requested a review from a team March 9, 2024 20:08

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Mar 9, 2024

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 9, 2024

nmussy mentioned this pull request Mar 10, 2024

(rds): auto-generate all RDS engine version types from API #12496

Open

2 tasks

lpizzinidev mentioned this pull request Mar 10, 2024

chore(rds): add oracle versions #29421

Closed

1 task

msambol reviewed Mar 10, 2024

View reviewed changes

msambol approved these changes Mar 10, 2024

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 10, 2024

lpizzinidev suggested changes Mar 10, 2024

View reviewed changes

lpizzinidev approved these changes Mar 10, 2024

View reviewed changes

nmussy mentioned this pull request Mar 10, 2024

chore(ec2): add missing instance types #29427

Merged

1 task

cgarvis mentioned this pull request Mar 11, 2024

feat(rds): add mysql 3.06.0 for aurora #29436

Closed

1 task

Merge branch 'main' into chore-rds-versions

ea20b85

paulhcsun approved these changes Mar 11, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 11, 2024

mergify bot merged commit bf33efd into aws:main Mar 11, 2024
13 checks passed

nmussy deleted the chore-rds-versions branch March 11, 2024 17:32

github-actions bot mentioned this pull request Apr 1, 2024

Monthly PR metrics report #29668

Closed

This was referenced May 21, 2024

chore(rds): deprecate unsupported aurora mysql versions #30282

Merged

chore(rds): update engine versions #30305

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(rds): update engine versions #29422

chore(rds): update engine versions #29422

nmussy commented Mar 9, 2024 •

edited

Loading

msambol Mar 10, 2024

nmussy Mar 10, 2024 •

edited

Loading

msambol left a comment

nmussy commented Mar 10, 2024

lpizzinidev left a comment

lpizzinidev Mar 10, 2024

nmussy Mar 10, 2024

lpizzinidev Mar 10, 2024

nmussy Mar 10, 2024

lpizzinidev Mar 10, 2024

nmussy Mar 10, 2024

lpizzinidev Mar 10, 2024

nmussy Mar 10, 2024

lpizzinidev Mar 10, 2024

nmussy Mar 10, 2024

lpizzinidev Mar 10, 2024

nmussy Mar 10, 2024

lpizzinidev Mar 10, 2024

paulhcsun left a comment

aws-cdk-automation commented Mar 11, 2024

mergify bot commented Mar 11, 2024

		@@ -1841,67 +2249,159 @@ class OracleEeCdbInstanceEngine extends OracleInstanceEngineBase {
		* and `DatabaseInstanceEngine.sqlServerEe`).

chore(rds): update engine versions #29422

chore(rds): update engine versions #29422

Conversation

nmussy commented Mar 9, 2024 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Choose a reason for hiding this comment

nmussy Mar 10, 2024 • edited Loading

Choose a reason for hiding this comment

msambol left a comment

Choose a reason for hiding this comment

nmussy commented Mar 10, 2024

lpizzinidev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulhcsun left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Mar 11, 2024

AWS CodeBuild CI Report

mergify bot commented Mar 11, 2024

nmussy commented Mar 9, 2024 •

edited

Loading

nmussy Mar 10, 2024 •

edited

Loading