Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(elbv2): support specifying the weighted_random routing algorithm and enabling anomaly mitigation #29972

Conversation

gillesbergerp
Copy link

Issue # (if applicable)

Closes #29969.

Reason for this change

Enable anomaly mitigation for target groups.

Description of changes

  • Added the weighted_random algorithm type
  • Added a property for enabling anomaly mitigation

Description of how you validated changes

Unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2024 08:35
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Apr 26, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@gillesbergerp gillesbergerp changed the title feat(aws-elbv2): support specifying the weighted_random routing algorithm and enabling anomaly mitigation feat(elbv2): support specifying the weighted_random routing algorithm and enabling anomaly mitigation Apr 26, 2024
@gillesbergerp gillesbergerp force-pushed the gillesbergerp/feat-weighted-random-routing branch from 0064829 to a9579e8 Compare April 26, 2024 08:49
@gillesbergerp gillesbergerp force-pushed the gillesbergerp/feat-weighted-random-routing branch from a9579e8 to ef79da7 Compare April 26, 2024 09:52
@gillesbergerp
Copy link
Author

Unfortunately, I am unable to run the integration test. If that could be taken over by someone else, it would be very much appreciated

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ef79da7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This was referenced Apr 29, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 26, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-elasticloadbalancingv2): Add the weighted_random load balancing algorithm
3 participants