Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(codebuild): lambda build images fromEcrRepository #29973

Closed
wants to merge 2 commits into from
Closed

feat(codebuild): lambda build images fromEcrRepository #29973

wants to merge 2 commits into from

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Apr 26, 2024

WIP

Issue # (if applicable)

Closes #29964

Reason for this change

Description of changes

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/small Small work item – less than a day of effort distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2 labels Apr 26, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2024 08:40
nmussy
nmussy commented Apr 29, 2024
View reviewed changes
...ws-cdk-testing/framework-integ/test/aws-codebuild/test/integ.docker-registry-build-images.ts
// DO NOT USE YOUR ACCOUNT PASSWORD, USE A GENERATED PERSONAL ACCESS TOKEN
// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
password: // PASSWORD SHOULD NOT BE YOUR ACTUAL PASSWORD
'dckr_pat_I4j7TDEb_X92cW0MGB3FVZ_AlYc',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This access token was mine, and has already been invalidated. I've already "unblocked" the secret on my personal repo, but it might be an issue again when we try to merge this?

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e05a3e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Sep 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CodeBuild: Custom Lambda Images
2 participants
@nmussy @aws-cdk-automation