Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ecs): removed omitEmptyArray for placementConstraints (#27555) #30370

Closed
wants to merge 2 commits into from

Conversation

stm29
Copy link
Contributor

@stm29 stm29 commented May 29, 2024

Issue

Closes #27555

Reason for this change

Users unable to give empty placementConstraints

Description of changes

  • Removed omitEmptyArray for placementConstraints, which allows to set []

Description of how you validated changes

  • Changed 1 existing unit test no placementConstraints
  • Added a UnitCase with empty [] placementConstraints
  • Integration Tests
$ yarn integ test/aws-ecs/test/ec2/integ.placement-constraint-default-empty.js --update-on-failed
  • After integ tests were completed, npm test to verify the snapsho.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 29, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team May 29, 2024 11:01
@github-actions github-actions bot added bug This issue is a bug. p1 labels May 29, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 823eded
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@stm29
Copy link
Contributor Author

stm29 commented May 30, 2024

Created Successfully Builded PR - pr / 30382 , But unfortunately it went as p2

@stm29 stm29 closed this May 30, 2024
@stm29 stm29 deleted the fix-omitEmptyArray-ecs-27555 branch May 30, 2024 13:04
This was referenced Jun 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cdk.aws_ecs: empty placement constraints / placement strategies not allowed
2 participants