-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs(ecs): describe default tag value for fromEcrRepository method #30926
docs(ecs): describe default tag value for fromEcrRepository method #30926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Going to remove the space and then approve.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Description of changes
If we don't specify the tag parameter for fromEcrRepository method,
latest
is used as default value.aws-cdk/packages/aws-cdk-lib/aws-ecs/lib/container-image.ts
Lines 19 to 24 in c8e5924
However, currently this behavior is not described in document.
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.ContainerImage.html#static-fromwbrecrwbrrepositoryrepository-tag
I'm adding the description regarding this default value.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license