-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs(ses): corrected default value as true for ConfigurationSet.reputationMetrics property #30979
docs(ses): corrected default value as true for ConfigurationSet.reputationMetrics property #30979
Conversation
…ationMetrics property
Thank you. Based on your verification on the console #30968 (comment) leaving it undefined would make it enabled by CFN so I think this PR should be good. LGTM but I'll let the maintainer to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed on my end as well that it defaults to true in the console, thank you!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30968.
Reason for this change
The default value of
ConfigurationSet.reputationMetrics
if not set in the CDK stack is actuallytrue
(refer #30968 (comment) for details).Description of changes
Corrected default value as
true
forConfigurationSet.reputationMetrics
property in documentation comment.Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license