Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(aws-eks): adding takeOwnership option to HelmChart construct #32981

Closed
wants to merge 1 commit into from

Conversation

hanseltime
Copy link

Issue # (if applicable)

Closes #..

Reason for this change

Fulfilling the linked issue, this adds the new functionality flag of --take-ownership of Helm v3.17.0 to the HelmChart
custom resource.

Description of changes

  • Adds a new TakeOwnership payload parameter to the KubectlHandler custom resource function
  • Uses that payload to add the --take-ownership flag in the helm call in the custom resource function
  • Adds takeOwnership as an optional property to the HelmChart Construct
  • All default parameters are set to false to keep backward compatibility

Describe any new or updated permissions being added

No new permissions should be needed for this change.

Description of how you validated changes

  1. Unit tests are added to verify the defaults and setting of takeOwnership in HelmChart
  2. Integration tests are updated to:
    1. Use a non-deprecated EKS cluster (1.31) and standard KubectlLayer
    2. Create a helm chart with take-ownership set to verify the functionality doesn't break
    3. TODO - Until This kubectl layer PR is accepted, we can't update snapshots since no layers have the newest version of helm.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 17, 2025 06:48
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title scope of the pull request should omit 'aws-' from the name of modified packages. Use 'eks' instead of 'aws-eks'.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@hanseltime hanseltime force-pushed the feat-helm-take-ownership branch from 3ecd6ad to ccf0676 Compare January 19, 2025 20:30
@hanseltime hanseltime force-pushed the feat-helm-take-ownership branch from ccf0676 to b7dc8eb Compare January 19, 2025 20:35
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b7dc8eb
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Feb 16, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants