Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(cli): show all information from waiter errors #33035

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

otaviomacedo
Copy link
Contributor

Waiter errors now have an additional piece of information: the responses that were observed during the polling, and their counts.

Relay this information to the user in the error message.

Closes #32481.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@otaviomacedo otaviomacedo requested a review from a team as a code owner January 21, 2025 14:50
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jan 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2025 14:50
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33035/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@otaviomacedo otaviomacedo added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.50%. Comparing base (94ba772) to head (a7eccb7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33035      +/-   ##
==========================================
+ Coverage   81.46%   81.50%   +0.03%     
==========================================
  Files         224      224              
  Lines       13748    13755       +7     
  Branches     2412     2413       +1     
==========================================
+ Hits        11200    11211      +11     
+ Misses       2273     2270       -3     
+ Partials      275      274       -1     
Flag Coverage Δ
suite.unit 81.50% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.93% <87.50%> (+0.07%) ⬆️
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a7eccb7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@otaviomacedo otaviomacedo merged commit b512a72 into main Jan 22, 2025
16 of 18 checks passed
@otaviomacedo otaviomacedo deleted the otaviom/waiter-error branch January 22, 2025 08:30
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: everywhere we use a waiter we have to adjust the message to take waiter errors into account
3 participants