Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(eslint): lint against padded lines after class declarations #33071

Merged
merged 11 commits into from
Jan 22, 2025

Conversation

kaizencc
Copy link
Contributor

Linter rule to ensure that we don't have padded lines within our class declarations. This helps standardize a pattern that we review for already.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from a team as a code owner January 22, 2025 19:44
@github-actions github-actions bot added the p2 label Jan 22, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 22, 2025 19:44
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 22, 2025
@kaizencc kaizencc changed the title chore(eslint): lint against padded lines after chore(eslint): lint against padded lines after class declarations Jan 22, 2025
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.

@GavinZZ GavinZZ added the pr/do-not-merge This PR should not be merged at this time. label Jan 22, 2025
@GavinZZ
Copy link
Contributor

GavinZZ commented Jan 22, 2025

I added a pr/do-not-merge to check if Momo has any feedback. If not, feel free to remove the label.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.52%. Comparing base (066cd4f) to head (0570b3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33071   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         224      224           
  Lines       13762    13762           
  Branches     2414     2414           
=======================================
  Hits        11220    11220           
  Misses       2270     2270           
  Partials      272      272           
Flag Coverage Δ
suite.unit 81.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.93% <ø> (ø)
packages/aws-cdk-lib/core 82.15% <ø> (ø)

@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Jan 22, 2025
@kaizencc
Copy link
Contributor Author

Momo would be happy with this, i think. removing DNM but also wrestling with the build

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0570b3d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 704ff0b into main Jan 22, 2025
19 of 20 checks passed
@mergify mergify bot deleted the conroy/blocklint branch January 22, 2025 23:57
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants