-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
refactor(cli): remove unused code #33096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33096/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed, add Clarification Request
to a comment.
Added |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33096 +/- ##
==========================================
- Coverage 81.52% 81.51% -0.02%
==========================================
Files 224 223 -1
Lines 13762 13752 -10
Branches 2414 2413 -1
==========================================
- Hits 11220 11210 -10
Misses 2270 2270
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Force merged to bypass Codecov for this dead code removal PR. |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
This file is completely unused in our code base.
The test also doesn't test anything by indirection.
Description of changes
Removed the unused file and test.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Searched for the function on GitHub and internally. All found references are copies of the CDK code base and don't represent actual usage of the exported function.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license