Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(cli): remove unused code #33096

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jan 23, 2025

Reason for this change

This file is completely unused in our code base.
The test also doesn't test anything by indirection.

Description of changes

Removed the unused file and test.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Searched for the function on GitHub and internally. All found references are copies of the CDK code base and don't represent actual usage of the exported function.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner January 23, 2025 13:46
@github-actions github-actions bot added the p2 label Jan 23, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2025 13:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 23, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/33096/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Jan 23, 2025
@mrgrain
Copy link
Contributor Author

mrgrain commented Jan 23, 2025

Added pr-linter/cli-integ-tested but didn't actually do that. Seems low risk and the change will go through the pipeline on main anyway.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (e4703c1) to head (f25ffaa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33096      +/-   ##
==========================================
- Coverage   81.52%   81.51%   -0.02%     
==========================================
  Files         224      223       -1     
  Lines       13762    13752      -10     
  Branches     2414     2413       -1     
==========================================
- Hits        11220    11210      -10     
  Misses       2270     2270              
  Partials      272      272              
Flag Coverage Δ
suite.unit 81.51% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.90% <ø> (-0.03%) ⬇️
packages/aws-cdk-lib/core 82.15% <ø> (ø)

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 23, 2025 14:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f25ffaa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 23, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain merged commit 8506d31 into main Jan 23, 2025
40 of 42 checks passed
@mrgrain mrgrain deleted the mrgrain/chore/remove-unused-code branch January 23, 2025 14:41
@mrgrain
Copy link
Contributor Author

mrgrain commented Jan 23, 2025

Force merged to bypass Codecov for this dead code removal PR.

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants