chore(toolkit): register valid message codes #33160
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33160 +/- ##
=======================================
Coverage 80.78% 80.78%
=======================================
Files 232 232
Lines 14111 14111
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2431 2431
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| import { ToolkitError } from '../../errors'; | ||
| import { IoMessageCode } from '../io-message'; | ||
|
|
||
| export const CODES = { |
There was a problem hiding this comment.
some of these codes could be consolidated and/or their numbers could make a little more sense, but i personally have no idea if there should be any rhyme or reason to the codes. so leaving it as is in this PR
aws-cdk-automation
added
the
pr/needs-maintainer-review
Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Begins a registry of valid codes that are currently in use within the toolkit, and requires that only registered codes are used.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license