fix(lambda): deprecate feature flag @aws-cdk/aws-lambda:createNewPoliciesWithAddToRolePolicy #33689
Conversation
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
QuantumNeuralCoder
added
the
pr/do-not-merge
QuantumNeuralCoder
removed
the
pr/do-not-merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33689 +/- ##
==========================================
+ Coverage 82.24% 82.37% +0.13%
==========================================
Files 119 120 +1
Lines 6875 6933 +58
Branches 1161 1169 +8
==========================================
+ Hits 5654 5711 +57
- Misses 1118 1119 +1
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| However in the current implementation, we have removed a dependency of the lambda function on the policy. In addition to this, a Role will be attached to the Policy instead of an inline policy being attached to the role. | ||
| This will create a data race condition in the CloudFormation template because the creation of the Lambda function no longer waits for the policy to be created. | ||
| We recommend to unset the feature flag if already set which will restore the original behavior. |
There was a problem hiding this comment.
I think we should mention if people are okay with the fact that lambda may be created before policy, and they're experiencing circular dependency issue, they can consider setting it to true.
There was a problem hiding this comment.
addressed.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
#33688
Closes #.
33688
Reason for this change
Described in the #33688
Description of changes
Set default value of feature flag to false.
Updated description to indicate deprecated feature flag.
Update description to describe the race condition issue which led to this decision.
N/A
Describe any new or updated permissions being added
N/A
Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license