Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

API Rate Limiter #243

Merged
merged 1 commit into from
Nov 7, 2022
Merged

API Rate Limiter #243

merged 1 commit into from
Nov 7, 2022

Conversation

runakash
Copy link
Member

@runakash runakash commented Nov 7, 2022

Issue #, if available: Fixes #36

Description of changes: Add rate limiter to the AWS CloudMap API calls. We are noticing increase throttling for few customers, this will align controller's api limits with Cloudmap's.
Increasing the base delay of the service export reconciler's rate limiter, this will increase the back-off period if AWS CloudMap is having a downtime.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

… of the service export reconciler's rate limiter.
@runakash runakash requested a review from astaticvoid November 7, 2022 21:13
@codecov-commenter
Copy link

Codecov Report

Merging #243 (ed3bd01) into main (3f1bd63) will decrease coverage by 0.64%.
The diff coverage is 13.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   71.55%   70.91%   -0.65%     
==========================================
  Files          16       16              
  Lines        1747     1767      +20     
==========================================
+ Hits         1250     1253       +3     
- Misses        411      425      +14     
- Partials       86       89       +3     
Impacted Files Coverage Δ
...ntrollers/multicluster/serviceexport_controller.go 39.04% <0.00%> (-0.69%) ⬇️
pkg/cloudmap/api.go 75.00% <17.64%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1bd63...ed3bd01. Read the comment docs.

@runakash runakash merged commit 2db7055 into aws:main Nov 7, 2022
@runakash runakash deleted the add-api-rate-limiter branch November 15, 2022 18:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Cloud Map client-side traffic throttling
3 participants