chore: Remove Dafny warnings #1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all Dafny warnings and set warnings to error.
By removing all the errors,
--allow-warnings can be removed from verification.
This means that any verification warning will now fail the build.
This is especially relevant if {:only} is ever committed.
See aws/aws-cryptographic-material-providers-library#517.
This would now cause CI verification to fail.
texastony
requested changes
Mar 21, 2025
DynamoDbEncryption/dafny/DynamoDbEncryptionTransforms/src/Index.dfy
Outdated
Show resolved
Hide resolved
DynamoDbEncryption/dafny/DynamoDbEncryptionTransforms/src/DdbMiddlewareConfig.dfy
Show resolved
Hide resolved
texastony
approved these changes
Mar 24, 2025
josecorella
pushed a commit
that referenced
this pull request
Apr 1, 2025
## [3.8.1](v3.8.0...v3.8.1) (2025-04-01) ### Fixes * return plaintext items in UnprocessedItems in BatchWriteIttem ([#1642](#1642)) ([7c7c8a1](7c7c8a1)) ### Maintenance * add Rust generated test vectors ([#1638](#1638)) ([a285eac](a285eac)) * bump mpl and smithy-dafny ([#1762](#1762)) ([8179af4](8179af4)) * **dafny:** let FileIO deal in uint8 rather than bv8 ([#1746](#1746)) ([428a013](428a013)) * **deps:** bump actions/setup-java from 3 to 4 in /.github/workflows ([#1367](#1367)) ([f04bc40](f04bc40)) * **deps:** bump actions/setup-java from 3 to 4 in /.github/workflows ([#1654](#1654)) ([ddb69e1](ddb69e1)) * **deps:** bump org.junit.jupiter:junit-jupiter-api ([#1656](#1656)) ([d988c6e](d988c6e)) * **deps:** bump org.junit.jupiter:junit-jupiter-engine ([#1650](#1650)) ([4f18689](4f18689)) * **deps:** bump software.amazon.awssdk:bom ([#1643](#1643)) ([4c41746](4c41746)) * **deps:** bump software.amazon.awssdk:bom ([#1644](#1644)) ([84e2c56](84e2c56)) * **deps:** bump software.amazon.awssdk:core ([#1645](#1645)) ([dec98d6](dec98d6)) * **GHA:** Run Java CI testing for MPL Latest Release ([#1605](#1605)) ([2eb36b3](2eb36b3)) * **java:** allow local testing v3.8.0 ([#1628](#1628)) ([119a42b](119a42b)) * **java:** update versions of lombok and aws-sdk-ddb ([#1646](#1646)) ([099014e](099014e)) * re-enable Dafny for MacOS ([#1738](#1738)) ([6f729c3](6f729c3)) * Remove Dafny warnings ([#1742](#1742)) ([4a9d617](4a9d617)) * **rust:** enable wrapped client test vectors ([#1648](#1648)) ([20fee58](20fee58))
josecorella
pushed a commit
that referenced
this pull request
Apr 1, 2025
* return plaintext items in UnprocessedItems in BatchWriteIttem ([#1642](#1642)) ([7c7c8a1](7c7c8a1)) * add Rust generated test vectors ([#1638](#1638)) ([a285eac](a285eac)) * bump mpl and smithy-dafny ([#1762](#1762)) ([8179af4](8179af4)) * **dafny:** let FileIO deal in uint8 rather than bv8 ([#1746](#1746)) ([428a013](428a013)) * **deps:** bump actions/setup-java from 3 to 4 in /.github/workflows ([#1367](#1367)) ([f04bc40](f04bc40)) * **deps:** bump actions/setup-java from 3 to 4 in /.github/workflows ([#1654](#1654)) ([ddb69e1](ddb69e1)) * **deps:** bump org.junit.jupiter:junit-jupiter-api ([#1656](#1656)) ([d988c6e](d988c6e)) * **deps:** bump org.junit.jupiter:junit-jupiter-engine ([#1650](#1650)) ([4f18689](4f18689)) * **deps:** bump software.amazon.awssdk:bom ([#1643](#1643)) ([4c41746](4c41746)) * **deps:** bump software.amazon.awssdk:bom ([#1644](#1644)) ([84e2c56](84e2c56)) * **deps:** bump software.amazon.awssdk:core ([#1645](#1645)) ([dec98d6](dec98d6)) * **GHA:** Run Java CI testing for MPL Latest Release ([#1605](#1605)) ([2eb36b3](2eb36b3)) * **java:** allow local testing v3.8.0 ([#1628](#1628)) ([119a42b](119a42b)) * **java:** update versions of lombok and aws-sdk-ddb ([#1646](#1646)) ([099014e](099014e)) * re-enable Dafny for MacOS ([#1738](#1738)) ([6f729c3](6f729c3)) * Remove Dafny warnings ([#1742](#1742)) ([4a9d617](4a9d617)) * **rust:** enable wrapped client test vectors ([#1648](#1648)) ([20fee58](20fee58))
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all Dafny warnings and set warnings to error. By removing all the errors,
--allow-warnings can be removed from verification. This means that any verification warning will now fail the build. This is especially relevant if {:only} is ever committed. See aws/aws-cryptographic-material-providers-library#517. This would now cause CI verification to fail.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.