Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: port internal event stream changes #288

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Conversation

MikeDombo
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MikeDombo MikeDombo marked this pull request as ready for review June 7, 2022 19:35
@MikeDombo MikeDombo requested review from bretambrose and graebm June 7, 2022 20:50
@MikeDombo
Copy link
Contributor Author

@bretambrose any idea why the doc check is upset with files that are unchanged?

@bretambrose
Copy link
Contributor

Doc check was recently added. Those are things that have never had doc strings. Going to force merge this and then backfill them later.

@bretambrose bretambrose merged commit a39cab3 into main Jun 8, 2022
@bretambrose bretambrose deleted the gg-externalize branch June 8, 2022 19:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants