Mention the default ClientID in the sample readme #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
approved these changes
Jul 19, 2022
|
The changes looked fine but the CI is failing the check-docs. |
|
Thanks! Merging into The check-docs has been failing for awhile since we merged in changes and did not document them. The Windows CI seems to be having the issue where it gets stuck on the Greengrass tests and times out, but that is unrelated to this PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a note to mention the default client ID used for the samples, reducing confusion on what client ID is needed. This is especially helpful if you are transitioning from the V1 SDK and are trying to use a V1 SDK sample policy, as the V1 SDK samples use a different default client ID.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.