Skip to content

Set application logger for k8s klog as well #1152

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

der-eismann
Copy link
Contributor

@der-eismann der-eismann commented Mar 25, 2025

Issue #, if available:
Fixes #1150

Description of changes:

As mentioned in #1150 the logs coming from the k8s library directly were in a different logging format. With this change it should be the same (see kubernetes/client-go#18), I now got this:

{"level":"info","v":0,"time":"2025-03-25T11:03:13Z","message":"Waited for 1.192318364s due to client-side throttling, not priority and fairness, request: GET:https://10.10.0.1:443/api/v1/namespaces/default/pods/my-pod-5d447b475f-wrz7l"}

How you tested your changes:
Environment (Linux / Windows): Linux
Kubernetes Version: 1.32

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@der-eismann der-eismann marked this pull request as ready for review March 25, 2025 13:39
@der-eismann der-eismann requested a review from a team as a code owner March 25, 2025 13:39
@Lu-David Lu-David self-requested a review March 31, 2025 20:07
@Lu-David Lu-David merged commit b1181bf into aws:main Apr 14, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON logging not applied for k8s dependencies
2 participants